Skip to content

Conversation

@tetienne
Copy link
Collaborator

@tetienne tetienne commented Jan 9, 2026

Summary

Improves code quality tooling and CI efficiency.

Code quality:

  • Enable additional ruff rules: ASYNC, S (security), T (print detection), C4 (comprehensions)
  • Add actionlint pre-commit hook to validate GitHub workflow files

CI efficiency:

  • Add UV caching to lint and test workflows
  • Fix shellcheck warnings in release workflow

Maintenance:

  • Change dependabot from daily to weekly updates
  • Remove unused tox dependency

Copy link
Owner

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +70 to +78
[tool.ruff.lint.per-file-ignores]
# Tests: S101 (assert) is expected, ASYNC230 (blocking open) is acceptable for fixtures
"tests/**/*.py" = ["S101", "ASYNC230"]
# S105: OAuth client secrets are public by design (embedded in mobile apps)
"pyoverkiz/const.py" = ["S105"]
# S105: Enum values contain "TOKEN" or "PASS" in API names, not passwords
"pyoverkiz/enums/*.py" = ["S105"]
# Utility scripts can use print
"utils/**/*.py" = ["T201"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be to have these ignores in the file itself, so we can more easily spot it next to the code and eventually remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants